no bash needed, document and readability fixes

diff --git a/wwwbin/checkrepo.sh b/wwwbin/checkrepo.sh
index f391039eb1b10280da561f1044c41942df7e44fe..db2cff1bc34739323513d2f7b17956d6fc9964f7 100755 (executable)
--- a/wwwbin/checkrepo.sh
+++ b/wwwbin/checkrepo.sh
@@ -1,14 +1,27 @@
-#!/bin/bash
-# it's bash because mksh can do only 32bit arithemtic
+#!/bin/sh
+# stat(1) each file in .info to see if they exist
 
 REPODIR=${1:-/home/pld/admins/th/ftp/test}
 
+# expand files from .info file
+expand_info() {
+       awk -F ':' -vD="$REPODIR/" '
+               /file:/ {
+                       if (/-debuginfo-/) {
+                               print D $2 "/debuginfo/" $3
+                       } else {
+                               print D $2 "/RPMS/" $3
+                       }
+               }
+       ' "$@"
+}
+
 i=0
 nn=
 ls -1 $REPODIR/SRPMS/RPMS | sed -rne "s/^((.+)-[^-]+-[^-]+\.src\.rpm)$/\1.info/p" | \
-while read pkg ; do
-       for f in `awk -F ':' -vD="$REPODIR/" '/file:/ { if ($0 ~ /-debuginfo-/) { print D $2 "/debuginfo/" $3 } else { print D $2 "/RPMS/" $3 }}' $REPODIR/SRPMS/.metadata/$pkg` ; do
-               if ! stat $f &>/dev/null ; then
+while read pkg; do
+       for f in $(expand_info $REPODIR/SRPMS/.metadata/$pkg); do
+               if ! stat $f >/dev/null; then
                        echo "!!!: $pkg : $f" >&2
                fi
        done