]>
Commit | Line | Data |
---|---|---|
51a5ef0f PS |
1 | http://sourceware.org/ml/gdb-patches/2010-09/msg00273.html |
2 | Subject: [patch] .gdb_index: Fix Ada regression | |
3 | ||
4 | Hi, | |
5 | ||
6 | on a system with libraries using .gdb_index all the Ada testcases FAIL: | |
7 | ||
8 | Running ./gdb.ada/print_pc.exp ... | |
9 | FAIL: gdb.ada/print_pc.exp: start inferior (GDB internal error) | |
10 | FAIL: gdb.ada/print_pc.exp: p /x $pc | |
11 | ||
12 | dwarf2read.c:2374: internal-error: map_ada_symtabs called via index method | |
13 | ||
14 | FAIl is on Fedora 14 snapshot using gcc-debuginfo-4.5.1-3.fc14.x86_64 file: | |
15 | /usr/lib/debug/lib64/libgcc_s-4.5.1-20100907.so.1.debug | |
16 | ||
17 | The regressions get fixed on x86_64-fedora14snapshot-linux-gnu by the attached | |
18 | patch. No regressions on {x86_64,x86_64-m32,i686}-fedora14snapshot-linux-gnu. | |
19 | ||
20 | During my tests with `set language ada' I could not lookup non-Ada symbols | |
21 | anyway so I believe the patch is OK but sure it needs an Ada-wise review. | |
22 | ||
23 | ||
24 | Thanks, | |
25 | Jan | |
26 | ||
27 | ||
28 | gdb/ | |
29 | 2010-09-14 Jan Kratochvil <jan.kratochvil@redhat.com> | |
30 | ||
31 | * dwarf2read.c (dw2_map_ada_symtabs): Remove the internal_error. | |
32 | Update the comment. | |
33 | ||
34 | --- a/gdb/dwarf2read.c | |
35 | +++ b/gdb/dwarf2read.c | |
36 | @@ -2369,10 +2369,9 @@ dw2_map_ada_symtabs (struct objfile *objfile, | |
37 | domain_enum namespace, int wild, | |
38 | void *data) | |
39 | { | |
40 | - /* For now, we don't support Ada, so this function can't be | |
41 | - reached. */ | |
42 | - internal_error (__FILE__, __LINE__, | |
43 | - _("map_ada_symtabs called via index method")); | |
44 | + /* For now, we don't support Ada. Still the function can be called if the | |
45 | + current language is Ada for a non-Ada objfile using GNU index. As Ada | |
46 | + does not look for non-Ada symbols this function should just return. */ | |
47 | } | |
48 | ||
49 | static void | |
50 |