]>
Commit | Line | Data |
---|---|---|
10b774ae JP |
1 | [[[ |
2 | Fix segfault when subversion is built with gnome keyring support and keyring | |
3 | password lookup fails. | |
4 | ||
5 | * subversion/libsvn_subr/simple_providers.c | |
6 | (svn_auth__simple_creds_cache_get): Initialize 'done' with FALSE since ie | |
7 | password_get_gnome_keyring sets 'done' only to TRUE. In case of error | |
8 | it leaves unintialized 'done' (usually non 0) and default_password with NULL | |
9 | causing segfault at subsequent strcmp. | |
10 | ]]] | |
11 | Index: subversion/libsvn_subr/simple_providers.c | |
12 | =================================================================== | |
13 | --- subversion/libsvn_subr/simple_providers.c (revision 1835628) | |
14 | +++ subversion/libsvn_subr/simple_providers.c (working copy) | |
15 | @@ -206,7 +206,7 @@ | |
16 | { | |
17 | if (have_passtype) | |
18 | { | |
19 | - svn_boolean_t done; | |
20 | + svn_boolean_t done = FALSE; | |
21 | ||
22 | SVN_ERR(password_get(&done, &default_password, creds_hash, | |
23 | realmstring, username, parameters, |