projects / packages / kernel.git / blame
| Commit | Line | Data |
|---|---|---|
| d6e79c0d JR |
1 | Hello, |
| 2 | ||
| 3 | > On Wed, 22 Aug 2001, Jan Kara wrote: | |
| 4 | > | |
| 5 | > > Hello, | |
| 6 | > > | |
| 7 | > > Jan Sanislo <oystr@cs.washington.edu> found a bug in ext2 quota code in 2.4.6+. | |
| 8 | > > During changes in ext2 code in 2.4.6 some DQUOT_INIT()s were removed but they | |
| 9 | > > shouldn't and as a result quota is not computed right. | |
| 10 | > > The patch which adds missing DQUOT_INIT()s is below. I didn't place DQUOT_INIT()s to | |
| 11 | > > original places but rather to generic vfs parts which seems better to me. | |
| 12 | > > Please apply - patch is against 2.4.8. | |
| 13 | > | |
| 14 | > Wrong place - DQUOT_INIT should be in iput(), just before the call of | |
| 15 | > ->delete_inode() | |
| 16 | OK. I was also thinking about this place but finally I chose those places in namei.c.. | |
| 17 | bad choice :) | |
| 18 | The patch which places DQUOT_INIT() in iput() is below. Please apply. | |
| 19 | ||
| 20 | Honza | |
| 21 | -- | |
| 22 | Jan Kara <jack@suse.cz> | |
| 23 | SuSE Labs | |
| 24 | ------------------------------------------------------------------------------------ | |
| 25 | ||
| 26 | --- linux-2.4.9/fs/inode.c Wed Aug 22 17:00:51 2001 | |
| 27 | +++ linux-2.4.9/fs/inode.c Wed Aug 22 17:01:11 2001 | |
| 28 | @@ -1049,6 +1049,7 @@ | |
| 29 | ||
| 30 | if (op && op->delete_inode) { | |
| 31 | void (*delete)(struct inode *) = op->delete_inode; | |
| 32 | + DQUOT_INIT(inode); | |
| 33 | /* s_op->delete_inode internally recalls clear_inode() */ | |
| 34 | delete(inode); | |
| 35 | } else | |
| 36 | - | |
| 37 | To unsubscribe from this list: send the line "unsubscribe linux-kernel" in | |
| 38 | the body of a message to majordomo@vger.kernel.org | |
| 39 | More majordomo info at http://vger.kernel.org/majordomo-info.html | |
| 40 | Please read the FAQ at http://www.tux.org/lkml/ |