]>
Commit | Line | Data |
---|---|---|
6a06f6d8 JP |
1 | |
2 | # HG changeset patch | |
3 | # User Henrik Skupin <mail@hskupin.info> | |
4 | # Date 1597313122 0 | |
5 | # Node ID 46b078983080ca4d87e2305d781855b080fc1643 | |
6 | # Parent 082de8244278d76f9d6d216a7fd5da772b5152d3 | |
7 | Bug 1658870 - [geckodriver] Remove Firefox version check for acceptInsecureCerts. r=webdriver-reviewers,jgraham | |
8 | ||
9 | Differential Revision: https://phabricator.services.mozilla.com/D86917 | |
10 | ||
11 | diff --git a/testing/geckodriver/src/capabilities.rs b/testing/geckodriver/src/capabilities.rs | |
12 | --- a/testing/geckodriver/src/capabilities.rs | |
13 | +++ b/testing/geckodriver/src/capabilities.rs | |
14 | @@ -127,26 +127,17 @@ impl<'a> BrowserCapabilities for Firefox | |
15 | } else if cfg!(target_os = "linux") { | |
16 | Some("linux".into()) | |
17 | } else { | |
18 | None | |
19 | }) | |
20 | } | |
21 | ||
22 | fn accept_insecure_certs(&mut self, _: &Capabilities) -> WebDriverResult<bool> { | |
23 | - let binary = self.chosen_binary.clone(); | |
24 | - let version_str = self.version(binary.as_ref().map(|x| x.as_ref())); | |
25 | - if let Some(x) = version_str { | |
26 | - Ok(Version::from_str(&*x) | |
27 | - .or_else(|x| Err(convert_version_error(x)))? | |
28 | - .major | |
29 | - >= 52) | |
30 | - } else { | |
31 | - Ok(false) | |
32 | - } | |
33 | + Ok(true) | |
34 | } | |
35 | ||
36 | fn set_window_rect(&mut self, _: &Capabilities) -> WebDriverResult<bool> { | |
37 | Ok(true) | |
38 | } | |
39 | ||
40 | fn compare_browser_version( | |
41 | &mut self, | |
42 |