]>
Commit | Line | Data |
---|---|---|
c84df032 ER |
1 | To: vim-dev@vim.org |
2 | Subject: Patch 7.0.168 | |
3 | Fcc: outbox | |
4 | From: Bram Moolenaar <Bram@moolenaar.net> | |
5 | Mime-Version: 1.0 | |
6 | Content-Type: text/plain; charset=ISO-8859-1 | |
7 | Content-Transfer-Encoding: 8bit | |
8 | ------------ | |
9 | ||
10 | Patch 7.0.168 | |
11 | Problem: Using uninitialized memory and memory leak. (Dominique Pelle) | |
12 | Solution: Use alloc_clear() instead of alloc() for w_lines. Free | |
13 | b_ml.ml_stack after recovery. | |
14 | Files: src/memline.c, src/window.c | |
15 | ||
16 | ||
17 | *** ../vim-7.0.167/src/memline.c Wed Nov 1 18:10:36 2006 | |
18 | --- src/memline.c Thu Nov 16 22:29:19 2006 | |
19 | *************** | |
20 | *** 1329,1334 **** | |
21 | --- 1329,1335 ---- | |
22 | mf_put(mfp, hp, FALSE, FALSE); | |
23 | mf_close(mfp, FALSE); /* will also vim_free(mfp->mf_fname) */ | |
24 | } | |
25 | + vim_free(buf->b_ml.ml_stack); | |
26 | vim_free(buf); | |
27 | if (serious_error && called_from_main) | |
28 | ml_close(curbuf, TRUE); | |
29 | *** ../vim-7.0.167/src/window.c Tue Oct 24 21:15:09 2006 | |
30 | --- src/window.c Thu Nov 16 22:24:51 2006 | |
31 | *************** | |
32 | *** 4273,4279 **** | |
33 | win_T *wp; | |
34 | { | |
35 | wp->w_lines_valid = 0; | |
36 | ! wp->w_lines = (wline_T *)alloc((unsigned)(Rows * sizeof(wline_T))); | |
37 | if (wp->w_lines == NULL) | |
38 | return FAIL; | |
39 | return OK; | |
40 | --- 4273,4279 ---- | |
41 | win_T *wp; | |
42 | { | |
43 | wp->w_lines_valid = 0; | |
44 | ! wp->w_lines = (wline_T *)alloc_clear((unsigned)(Rows * sizeof(wline_T))); | |
45 | if (wp->w_lines == NULL) | |
46 | return FAIL; | |
47 | return OK; | |
48 | *** ../vim-7.0.167/src/version.c Tue Nov 21 19:36:00 2006 | |
49 | --- src/version.c Tue Nov 21 20:34:13 2006 | |
50 | *************** | |
51 | *** 668,669 **** | |
52 | --- 668,671 ---- | |
53 | { /* Add new patch number below this line */ | |
54 | + /**/ | |
55 | + 168, | |
56 | /**/ | |
57 | ||
58 | -- | |
59 | GALAHAD turns back. We see from his POV the lovely ZOOT standing by him | |
60 | smiling enchantingly and a number of equally delectable GIRLIES draped | |
61 | around in the seductively poulticed room. They look at him smilingly and | |
62 | wave. | |
63 | "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD | |
64 | ||
65 | /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\ | |
66 | /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ | |
67 | \\\ download, build and distribute -- http://www.A-A-P.org /// | |
68 | \\\ help me help AIDS victims -- http://ICCF-Holland.org /// |