]>
Commit | Line | Data |
---|---|---|
1dbfdfbe AM |
1 | From 038011b9121fff5ce0801e7ab3b49791079b91ac Mon Sep 17 00:00:00 2001 |
2 | From: Lukas Slebodnik <lslebodn@redhat.com> | |
3 | Date: Thu, 1 Dec 2016 13:13:21 +0100 | |
4 | Subject: [PATCH] SIFP: Fix warning format-security | |
5 | MIME-Version: 1.0 | |
6 | Content-Type: text/plain; charset=UTF-8 | |
7 | Content-Transfer-Encoding: 8bit | |
8 | ||
9 | dbus-1.11.8 added attributes for format string check to | |
10 | few functions in public header files. And therefore there is a warning. | |
11 | ||
12 | src/lib/sifp/sss_sifp_utils.c: In function ‘sss_sifp_set_io_error’: | |
13 | src/lib/sifp/sss_sifp_utils.c:44:5: error: format not a string literal | |
14 | and no format arguments [-Werror=format-security] | |
15 | dbus_set_error(ctx->io_error, error->name, error->message); | |
16 | ^~~~~~~~~~~~~~ | |
17 | --- | |
18 | src/lib/sifp/sss_sifp_utils.c | 2 +- | |
19 | 1 file changed, 1 insertion(+), 1 deletion(-) | |
20 | ||
21 | diff --git a/src/lib/sifp/sss_sifp_utils.c b/src/lib/sifp/sss_sifp_utils.c | |
22 | index ccd0518..dcac71f 100644 | |
23 | --- a/src/lib/sifp/sss_sifp_utils.c | |
24 | +++ b/src/lib/sifp/sss_sifp_utils.c | |
25 | @@ -41,7 +41,7 @@ void sss_sifp_set_io_error(sss_sifp_ctx *ctx, DBusError *error) | |
26 | { | |
27 | dbus_error_free(ctx->io_error); | |
28 | dbus_error_init(ctx->io_error); | |
29 | - dbus_set_error(ctx->io_error, error->name, error->message); | |
30 | + dbus_set_error(ctx->io_error, error->name, "%s", error->message); | |
31 | } | |
32 | ||
33 | char * sss_sifp_strdup(sss_sifp_ctx *ctx, const char *str) |