1 From FEDORA_PATCHES Mon Sep 17 00:00:00 2001
2 From: Fedora GDB patches <invalid@email.com>
3 Date: Fri, 27 Oct 2017 21:07:50 +0200
5 gdb-6.6-buildid-locate-misleading-warning-missing-debuginfo-rhbz981154.patch
7 FileName: gdb-6.6-buildid-locate-misleading-warning-missing-debuginfo-rhbz981154.patch
9 ;; Fix 'gdb gives highly misleading error when debuginfo pkg is present,
10 ;; but not corresponding binary pkg' (RH BZ 981154).
13 Comments by Sergio Durigan Junior <sergiodj@redhat.com>:
15 This is the fix for RH BZ #981154
17 It is mainly a testcase addition, but a minor fix in the gdb/build-id.c
20 gdb/build-id.c was added by:
22 commit dc294be54c96414035eed7d53dafdea0a6f31a72
23 Author: Tom Tromey <tromey@redhat.com>
24 Date: Tue Oct 8 19:56:15 2013 +0000
26 and had a little thinko there. The variable 'filename' needs to be set to
27 NULL after it is free'd, otherwise the code below thinks that it is still
28 valid and doesn't print the necessary warning ("Try: yum install ...").
31 .../rhbz981154-misleading-yum-install-warning.exp | 97 ++++++++++++++++++++++
32 2 files changed, 101 insertions(+), 1 deletion(-)
33 create mode 100644 gdb/testsuite/gdb.base/rhbz981154-misleading-yum-install-warning.exp
35 diff --git a/gdb/build-id.c b/gdb/build-id.c
36 index 409a5b8c54..e2c1e81266 100644
39 @@ -592,7 +592,10 @@ build_id_to_debug_bfd (size_t build_id_len, const bfd_byte *build_id,
49 if (build_id_verify (abfd.get(), build_id_len, build_id))
51 diff --git a/gdb/testsuite/gdb.base/rhbz981154-misleading-yum-install-warning.exp b/gdb/testsuite/gdb.base/rhbz981154-misleading-yum-install-warning.exp
53 index 0000000000..bb70c5cf44
55 +++ b/gdb/testsuite/gdb.base/rhbz981154-misleading-yum-install-warning.exp
57 +# Copyright (C) 2014 Free Software Foundation, Inc.
59 +# This program is free software; you can redistribute it and/or modify
60 +# it under the terms of the GNU General Public License as published by
61 +# the Free Software Foundation; either version 3 of the License, or
62 +# (at your option) any later version.
64 +# This program is distributed in the hope that it will be useful,
65 +# but WITHOUT ANY WARRANTY; without even the implied warranty of
66 +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
67 +# GNU General Public License for more details.
69 +# You should have received a copy of the GNU General Public License
70 +# along with this program. If not, see <http://www.gnu.org/licenses/>.
72 +standard_testfile "normal.c"
74 +if { [prepare_for_testing ${testfile}.exp ${testfile} ${srcfile}] } {
78 +# Get the build-id of the file
79 +set build_id_debug_file [build_id_debug_filename_get $binfile]
80 +regsub -all ".debug$" $build_id_debug_file "" build_id_without_debug
83 +if { ![runto_main] } {
87 +# We first need to generate a corefile
88 +set escapedfilename [string_to_regexp [standard_output_file gcore.test]]
90 +gdb_test_multiple "gcore [standard_output_file gcore.test]" \
93 + -re "Saved corefile ${escapedfilename}\[\r\n\]+$gdb_prompt $" {
94 + pass "save a corefile"
95 + global core_supported
96 + set core_supported 1
98 + -re "Can't create a corefile\[\r\n\]+$gdb_prompt $" {
99 + unsupported "save a corefile"
100 + global core_supported
101 + set core_supported 0
105 +if {!$core_supported} {
109 +# Move the binfile to a temporary name
110 +remote_exec build "mv $binfile ${binfile}.old"
112 +# Reinitialize GDB and see if we get a yum/dnf warning
115 +gdb_reinitialize_dir $srcdir/$subdir
117 +with_test_prefix "first run:" {
118 + gdb_test "set build-id-verbose 1" "" \
119 + "set build-id-verbose"
121 + gdb_test "set debug-file-directory [file dirname [standard_output_file gcore.test]]" "" \
122 + "set debug-file-directory"
124 + gdb_test "core-file [standard_output_file gcore.test]" \
125 + "Missing separate debuginfo for the main executable file\r\nTry: (yum|dnf) --enablerepo='\\*debug\\*' install [standard_output_file $build_id_without_debug]\r\n.*" \
126 + "test first yum/dnf warning"
129 +# Now we define and create our .build-id
130 +file mkdir [file dirname [standard_output_file ${build_id_without_debug}]]
131 +# Cannot use "file link" (from TCL) because it requires the target file to
133 +remote_exec build "ln -s $binfile [standard_output_file ${build_id_without_debug}]"
135 +# Reinitialize GDB to get the second yum/dnf warning
138 +gdb_reinitialize_dir $srcdir/$subdir
140 +with_test_prefix "second run:" {
141 + gdb_test "set build-id-verbose 1" "" \
142 + "set build-id-verbose"
144 + gdb_test "set debug-file-directory [file dirname [standard_output_file gcore.test]]" "" \
145 + "set debug-file-directory"
147 + gdb_test "core-file [standard_output_file gcore.test]" \
148 + "Missing separate debuginfo for the main executable file\r\nTry: (yum|dnf) --enablerepo='\\*debug\\*' install $binfile\r\n.*" \
149 + "test second yum/dnf warning"
152 +# Leaving the link there will cause breakage in the next run.
153 +remote_exec build "rm -f [standard_output_file ${build_id_without_debug}]"