- use \001 instead ^A to find autodeps

Changed files:
    fetch-crl.spec -> 1.3
    no-modify-template.patch -> 1.2

diff --git a/fetch-crl.spec b/fetch-crl.spec
index 9fa940de2a1cf8388b373bf545d0317ec50c0db8..9e672893185268b2687c5a7897e5a1881c883d45 100644 (file)
--- a/fetch-crl.spec
+++ b/fetch-crl.spec
@@ -14,22 +14,6 @@ Patch0:              no-modify-template.patch
 BuildRequires: rpm-perlprov >= 4.1-13
 Requires:      openssl
 Obsoletes:     fetch-crl3
-# These requires are only added since file is currently broken so they don't get autogenerated.
-# https://bugzilla.redhat.com/show_bug.cgi?id=699548
-# (file(1) considers file 'data' as it sees ^A inside script)
-Requires:      /usr/bin/perl
-Requires:      perl(File::Basename)
-Requires:      perl(File::Temp)
-Requires:      perl(Getopt::Long)
-Requires:      perl(IO::Select)
-Requires:      perl(IPC::Open3)
-Requires:      perl(LWP)
-Requires:      perl(POSIX)
-Requires:      perl(Sys::Syslog)
-Requires:      perl(Time::Local)
-Requires:      perl(integer)
-Requires:      perl(strict)
-Requires:      perl(vars)
 BuildArch:     noarch
 BuildRoot:     %{tmpdir}/%{name}-%{version}-root-%(id -u -n)
 
@@ -43,8 +27,10 @@ files follow the hash.crl_url convention.
 %setup -q
 %patch0 -p1
 
-# use this to figure out deps
-#sed -i -e 's,\ 1,BLAAA,' %{name}
+# NOTE: this is literal ctrl+a here
+# see https://bugzilla.redhat.com/show_bug.cgi?id=699548
+# (file(1) considers file 'data' as it sees ^A inside script)
+sed -i -e 's,\ 1,\\001,' %{name}
 
 %install
 rm -rf $RPM_BUILD_ROOT

diff --git a/no-modify-template.patch b/no-modify-template.patch
index 7033efebb4dbf2dd9a22fbc728ca47750bcad314..4aacd9623fbe17ac9e8beaf35443d529663912b7 100644 (file)
--- a/no-modify-template.patch
+++ b/no-modify-template.patch
@@ -12,6 +12,14 @@ VERBOSE(3) Writing PEM file /etc/pki/esteid/crl//etc/pki/esteid/crl/ESTEID-SK_20
 should had been:
 VERBOSE(3) Writing PEM file /etc/pki/esteid/crl/ESTEID-SK_2007.r0.pem
 
+16:21:09  SamChi> glen: foreach does not copy the value, it assigns each value of the list to the variable
+16:21:31  SamChi> glen: unless it is not a valid lvalue, then it may have to be copied
+16:22:12  SamChi> $ perl -le '@a = qw(a b); foreach (@a) { $_ .= "foobar" }; print "@a"'
+16:22:12  SamChi> afoobar bfoobar
+16:22:55  SamChi> glen: oh, I was wrong about the second part
+16:23:03  SamChi> $ perl -le '@a = qw(a b); foreach my $v (@a, "c") { $v .= "foobar" }; print "@a"'
+16:23:03  SamChi> Modification of a read-only value attempted at -e line 1.
+
 --- fetch-crl-3.0.6/fetch-crl  2011-03-20 05:01:20.000000000 +0200
 +++ fetch-crl-3.0.6/fetch-crl  2011-06-11 11:30:58.731040625 +0300
 @@ -1873,13 +1879,14 @@