- more python 3.x fixes

diff --git a/PLD_Builder/build.py b/PLD_Builder/build.py
index bf38ff4b820f01fd07e519a18780fb4d00d232bb..fc9534f45698378b368cebe8ec3184a0cce31fbf 100644 (file)
--- a/PLD_Builder/build.py
+++ b/PLD_Builder/build.py
@@ -117,4 +117,4 @@ def build_all(r, build_fnc):
             notify.add_batch(batch, "SKIP")
 
     buildlogs.flush()
-    chroot.run("rm -f %s" % string.join(r.chroot_files))
+    chroot.run("rm -f %s" % r.chroot_files.join())

diff --git a/PLD_Builder/file_sender.py b/PLD_Builder/file_sender.py
index 597f3fcba41af17780b7d0d96f2f4533f304fcae..910a54c2f1728a29a52ad215e626b4f0447af901 100644 (file)
--- a/PLD_Builder/file_sender.py
+++ b/PLD_Builder/file_sender.py
@@ -197,7 +197,7 @@ def flush_queue(dir):
                 emails[d['Requester']] = 1
         e = emails.keys()
         m = mailer.Message()
-        m.set_headers(to = string.join(e, ", "),
+        m.set_headers(to = e.join(", "),
                       subject = "[%s] builder queue problem" % config.builder)
         m.write("there were problems sending files from queue %s:\n" % dir)
         m.write("problems:\n")

diff --git a/PLD_Builder/gpg.py b/PLD_Builder/gpg.py
index edb8dff81e3ad76839764813253072d09e5e7b7e..b820dcdf3d4821ee7d3acd7edf47e4c26994e2f9 100644 (file)
--- a/PLD_Builder/gpg.py
+++ b/PLD_Builder/gpg.py
@@ -27,7 +27,7 @@ def get_keys(buf):
     cmd = ['/usr/bin/gpg', '--batch', '--no-tty', '--decrypt']
     gpg_run = subprocess.Popen(cmd, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE, close_fds=True)
     try:
-        d_stdout, d_stderr = gpg_run.communicate(buf.encode('utf-8'))
+        d_stdout, d_stderr = gpg_run.communicate(buf.decode().encode('utf-8'))
     except OSError as e:
         log.error("gnupg run, does gpg binary exist? : %s" % e)
         raise
@@ -35,7 +35,7 @@ def get_keys(buf):
     rx = re.compile("^gpg:.*using\s[DR]SA\skey\s(?:ID\s)?(\w+)")
     keys = []
 
-    for l in d_stderr.split('\n'):
+    for l in d_stderr.decode().split('\n'):
         m = rx.match(l)
         if m:
             keys.append(m.group(1))
@@ -59,14 +59,14 @@ def verify_sig(buf):
     cmd = ['/usr/bin/gpg', '--batch', '--no-tty', '--decrypt']
     gpg_run = subprocess.Popen(cmd, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE, close_fds=True)
     try:
-        d_stdout, d_stderr = gpg_run.communicate(buf.encode('utf-8'))
+        d_stdout, d_stderr = gpg_run.communicate(buf.decode().encode('utf-8'))
     except OSError as e:
         log.error("gnupg run failed, does gpg binary exist? : %s" % e)
         raise
 
     rx = re.compile("^gpg: (Good signature from|                aka) .*<([^>]+)>")
     emails = []
-    for l in d_stderr.split('\n'):
+    for l in d_stderr.decode().split('\n'):
         m = rx.match(l)
         if m:
             emails.append(m.group(2))
@@ -85,12 +85,12 @@ def sign(buf):
     # TODO: check for gpg return code!
     gpg_run = subprocess.Popen(cmd, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE, close_fds=True)
     try:
-        d_stdout, d_stderr = gpg_run.communicate(buf.encode('utf-8'))
+        d_stdout, d_stderr = gpg_run.communicate(buf.decode().encode('utf-8'))
     except OSError as e:
         log.error("gnupg signing failed, does gpg binary exist? : %s" % e)
         raise
 
     if len(d_stderr):
-        log.error("gpg: %s" % d_stderr)
+        log.error("gpg: %s" % d_stderr.decode())
 
     return d_stdout

diff --git a/PLD_Builder/install.py b/PLD_Builder/install.py
index c5f4ce1d90d68bdbd4b3f149989d48acbdf52094..3f630fd67674033aec6684732cd5ea3e1f130f21 100644 (file)
--- a/PLD_Builder/install.py
+++ b/PLD_Builder/install.py
@@ -53,7 +53,7 @@ def close_killset(killset):
     return errors
 
 def upgrade_from_batch(r, b):
-    f = chroot.popen("rpm --test -F %s 2>&1" % string.join(b.files), user = "root")
+    f = chroot.popen("rpm --test -F %s 2>&1" % b.files.join(), user = "root")
     killset = {}
     rx = re.compile(r' \(installed\) (?P<name>[^\s]+)-[^-]+-[^-]+$')
     for l in f:
@@ -66,7 +66,7 @@ def upgrade_from_batch(r, b):
             util.append_to(b.logfile, err)
             log.notice("cannot upgrade rpms")
             return False
-        k = string.join(killset.keys())
+        k = killset.keys().join()
         if True:
             b.log_line("upgrade requires removal of %s" % k)
             res = chroot.run("rpm -e %s" % k, logfile = b.logfile, user = "root")
@@ -80,7 +80,7 @@ def upgrade_from_batch(r, b):
             return False
     b.log_line("upgrading packages")
     logbuf = StringIO.StringIO()
-    res = chroot.run("rpm -Fvh %s" % string.join(b.files), user = "root", logfile = b.logfile)
+    res = chroot.run("rpm -Fvh %s" % b.files.join(), user = "root", logfile = b.logfile)
     if res != 0:
         b.log_line("package upgrade failed")
         logbuf.close()

diff --git a/PLD_Builder/request.py b/PLD_Builder/request.py
index e1ecc69549eb2a233dde090b6f02fa00e7963944..fa2798f7471ca6ee39fbb45cd5882ea5cc99ce40 100644 (file)
--- a/PLD_Builder/request.py
+++ b/PLD_Builder/request.py
@@ -110,7 +110,7 @@ class Group:
     def dump(self, f):
         f.write("group: %d (id=%s pri=%d)\n" % (self.no, self.id, self.priority))
         f.write("  from: %s\n" % self.requester)
-        f.write("  flags: %s\n" % string.join(self.flags))
+        f.write("  flags: %s\n" % self.flags.join())
         f.write("  time: %s\n" % time.asctime(time.localtime(self.time)))
         for b in self.batches:
             b.dump(f)
@@ -148,7 +148,7 @@ class Group:
             'requester': escape(self.requester),
             'priority': self.priority,
             'max_jobs': self.max_jobs,
-            'flags': string.join(self.flags)
+            'flags': self.flags.join()
         })
         f.write("<ol>\n")
         for b in self.batches:
@@ -162,7 +162,7 @@ class Group:
          <requester email='%s'>%s</requester>
          <time>%d</time>
          <priority>%d</priority>
-         <maxjobs>%d</maxjobs>\n""" % (self.id, self.no, string.join(self.flags),
+         <maxjobs>%d</maxjobs>\n""" % (self.id, self.no, self.flags.join(),
                     escape(self.requester_email), escape(self.requester),
                     self.time, self.priority, self.max_jobs))
         for b in self.batches:
@@ -294,7 +294,7 @@ class Batch:
         builders = []
         for b in self.builders:
             builders.append("%s:%s" % (b, self.builders_status[b]))
-        f.write("    builders: %s\n" % string.join(builders))
+        f.write("    builders: %s\n" % builders.join())
 
     def is_command(self):
         return self.command != ""
@@ -392,7 +392,7 @@ class Batch:
                     'tooltip' : cgi.escape(tooltip, True),
             }
             + link_post)
-        f.write("%s]</small></li>\n" % string.join(builders))
+        f.write("%s]</small></li>\n" % builders.join())
 
     def rpmbuild_opts(self):
         """
@@ -492,7 +492,7 @@ class Batch:
            <spec>%s</spec>
            <branch>%s</branch>
            <info>%s</info>\n""" % (self.b_id,
-                 string.join(list(map(lambda b: b.b_id, self.depends_on))),
+                 list(map(lambda b: b.b_id, self.depends_on)).join(),
                  escape(self.src_rpm),
                  escape(' '.join(self.command_flags)), escape(self.command),
                  escape(self.spec), escape(self.branch), escape(self.info)))

diff --git a/PLD_Builder/request_handler.py b/PLD_Builder/request_handler.py
index e3c5ca1f6df7912510a1d04cecad42d65d5d777e..b6c67a57f3b6d7802b9e5ad01d1cb7cb1015187f 100644 (file)
--- a/PLD_Builder/request_handler.py
+++ b/PLD_Builder/request_handler.py
@@ -104,7 +104,7 @@ def handle_group(r, user):
             batch.builders_status_time[bld] = time.time()
             if bld not in config.binary_builders and bld != config.builder:
                 fail_mail("I (src rpm builder '%s') do not handle binary builder '%s', only '%s'" % \
-                        (config.builder, bld, string.join(config.binary_builders)))
+                        (config.builder, bld, config.binary_builders.join()))
                 lockf.close()
                 return
             if batch.is_command():

diff --git a/PLD_Builder/request_handler_server.py b/PLD_Builder/request_handler_server.py
index c512199ba6fa08717aea4624df2197236957602e..11840eae47c2fba84b4eb72e97e8f3ef80aea7d8 100644 (file)
--- a/PLD_Builder/request_handler_server.py
+++ b/PLD_Builder/request_handler_server.py
@@ -24,8 +24,8 @@ class MyHandler(BaseHTTPRequestHandler):
     def do_POST(self):
         global rootnode
         try:
-            length = int(self.headers.getheader('content-length'))
-            filename = self.headers.getheader('x-filename')
+            length = int(self.headers.get('content-length'))
+            filename = self.headers.get('x-filename')
             if not length:
                 log.error("request_handler_server: [%s]: 401 Unauthorized" % self.client_address[0])
                 self.send_error(401)

diff --git a/PLD_Builder/rpm_builder.py b/PLD_Builder/rpm_builder.py
index 2f70951312e6e98157bf7b7f94d8ce1fecac5071..0f6601c4541eb939be892ee479a0f365563a7432 100644 (file)
--- a/PLD_Builder/rpm_builder.py
+++ b/PLD_Builder/rpm_builder.py
@@ -283,7 +283,7 @@ def build_rpm(r, b):
             b.log_line("copy rpm files to cache_dir: %s" % rpm_cache_dir)
             chroot.run(
                     "cp -f %s %s && poldek --mo=nodiff --mkidxz -s %s/" % \
-                        (string.join(b.files), rpm_cache_dir, rpm_cache_dir),
+                        (b.files.join(), rpm_cache_dir, rpm_cache_dir),
                      logfile = b.logfile, user = "root"
             )
         else: