From: Jan Palus <atler@pld-linux.org>
Date: Sun, 5 Sep 2021 17:56:45 +0000 (+0200)
Subject: BR: glibc-debuginfo valgrind for tests; rel 2
X-Git-Tag: auto/th/libseccomp-2.5.2-2~2
X-Git-Url: http://git.pld-linux.org/gitweb.cgi?a=commitdiff_plain;h=41063362c7e41eb8e0e8273f2b7f29f691a8e679;p=packages%2Flibseccomp.git

BR: glibc-debuginfo valgrind for tests; rel 2

some tests rely on valgrind and valgrind appears to rely on
glibc-debuginfo:

valgrind: Fatal error at startup: a function redirection
valgrind: which is mandatory for this platform-tool combination
valgrind: cannot be set up. Details of the redirection are:
valgrind:
valgrind: A must-be-redirected function
valgrind: whose name matches the pattern: strlen
valgrind: in an object with soname matching: ld-linux-x86-64.so.2
valgrind: was not found whilst processing
valgrind: symbols from the object with soname: ld-linux-x86-64.so.2
valgrind:
valgrind: Possible fixes: (1, short term): install glibc's debuginfo
valgrind: package on this machine. (2, longer term): ask the packagers
valgrind: for your Linux distribution to please in future ship a non-
valgrind: stripped ld.so (or whatever the dynamic linker .so is called)
valgrind: that exports the above-named function using the standard
valgrind: calling conventions for this platform. The package you need
valgrind: to install for fix (1) is called

require both for consistent tests result (the other solution could be
simply BC: valgrind with supposedly lower test coverage)
---

diff --git a/libseccomp.spec b/libseccomp.spec
index eb6fca9..6e7f540 100644
--- a/libseccomp.spec
+++ b/libseccomp.spec
@@ -18,7 +18,7 @@ Summary:	Enhanced Seccomp (mode 2) Helper library
 Summary(pl.UTF-8):	Rozszerzona biblioteka pomocnicza Seccomp (trybu 2)
 Name:		libseccomp
 Version:	2.5.2
-Release:	1
+Release:	2
 License:	LGPL v2.1
 Group:		Libraries
 #Source0Download: https://github.com/seccomp/libseccomp/releases
@@ -39,6 +39,10 @@ BuildRequires:	python3-devel >= 1:3.3
 BuildRequires:	rpm-pythonprov
 BuildRequires:	rpmbuild(macros) >= 1.714
 %endif
+%if %{with tests}
+BuildRequires:	glibc-debuginfo
+BuildRequires:	valgrind
+%endif
 ExclusiveArch:	%{ix86} %{x8664} x32 %{arm} aarch64 mips mips64 parisc parisc64 ppc ppc64 riscv64 s390 s390x
 BuildRoot:	%{tmpdir}/%{name}-%{version}-root-%(id -u -n)