2 https://github.com/shadow-maint/shadow/issues/32
4 From 67d2bb6e0a5ac124ce1f026dd5723217b1493194 Mon Sep 17 00:00:00 2001
5 From: Serge Hallyn <serge@hallyn.com>
6 Date: Sun, 18 Sep 2016 21:31:18 -0500
7 Subject: [PATCH] su.c: fix missing length argument to snprintf
11 1 file changed, 2 insertions(+), 2 deletions(-)
13 diff --git a/src/su.c b/src/su.c
14 index 0c50a94..93ffd2f 100644
17 @@ -373,8 +373,8 @@ static void prepare_pam_close_session (void)
19 (void) kill (-pid_child, caught);
21 - snprintf (kill_msg, _(" ...killed.\n"));
22 - snprintf (wait_msg, _(" ...waiting for child to terminate.\n"));
23 + snprintf (kill_msg, 256, _(" ...killed.\n"));
24 + snprintf (wait_msg, 256, _(" ...waiting for child to terminate.\n"));
26 (void) signal (SIGALRM, kill_child);
28 From 924cc346475dea7dc394316cd7c3d5d0414e538e Mon Sep 17 00:00:00 2001
29 From: Adam Sampson <ats@offog.org>
30 Date: Thu, 15 Sep 2016 16:54:42 +0100
31 Subject: [PATCH] Use sizeof rather than hardcoding snprintf's size argument.
35 1 file changed, 2 insertions(+), 2 deletions(-)
37 diff --git a/src/su.c b/src/su.c
38 index 93ffd2f..d605af8 100644
41 @@ -373,8 +373,8 @@ static void prepare_pam_close_session (void)
43 (void) kill (-pid_child, caught);
45 - snprintf (kill_msg, 256, _(" ...killed.\n"));
46 - snprintf (wait_msg, 256, _(" ...waiting for child to terminate.\n"));
47 + snprintf (kill_msg, sizeof kill_msg, _(" ...killed.\n"));
48 + snprintf (wait_msg, sizeof wait_msg, _(" ...waiting for child to terminate.\n"));
50 (void) signal (SIGALRM, kill_child);