- honour AddHeader if specified multiple times. patch from mailinglist

[packages/pound.git] / pound-logfile.patch

--- Pound-2.4.3-logfile/config.c	2008-12-11 00:22:22.509353295 +0200
+++ Pound-2.4.3.logs/config.c	2009-01-08 17:47:08.523739629 +0200
@@ -72,7 +72,7 @@
 };
 #endif
 
-static regex_t  Empty, Comment, User, Group, RootJail, Daemon, LogFacility, LogLevel, Alive, SSLEngine, Control;
+static regex_t  Empty, Comment, User, Group, RootJail, Daemon, LogFacility, LogFile, LogLevel, ErrorLog, Alive, SSLEngine, Control;
 static regex_t  ListenHTTP, ListenHTTPS, End, Address, Port, Cert, xHTTP, Client, CheckURL;
 static regex_t  Err414, Err500, Err501, Err503, MaxRequest, HeadRemove, RewriteLocation, RewriteDestination;
 static regex_t  Service, ServiceName, URL, HeadRequire, HeadDeny, BackEnd, Emergency, Priority, HAport, HAportAddr;
@@ -1104,6 +1104,18 @@
                         def_facility = facilitynames[i].c_val;
                         break;
                     }
+        } else if(!regexec(&LogFile, lin, 4, matches, 0)) {
+            lin[matches[1].rm_eo] = '\0';
+            if((log_file = strdup(lin + matches[1].rm_so)) == NULL) {
+                logmsg(LOG_ERR, "line %d: LogFile config: out of memory - aborted", n_lin);
+                exit(1);
+            }
+        } else if(!regexec(&ErrorLog, lin, 4, matches, 0)) {
+            lin[matches[1].rm_eo] = '\0';
+            if((error_log = strdup(lin + matches[1].rm_so)) == NULL) {
+                logmsg(LOG_ERR, "line %d: ErrorLog config: out of memory - aborted", n_lin);
+                exit(1);
+            }
         } else if(!regexec(&Grace, lin, 4, matches, 0)) {
             grace = atoi(lin + matches[1].rm_so);
         } else if(!regexec(&LogLevel, lin, 4, matches, 0)) {
@@ -1204,7 +1216,9 @@
     || regcomp(&RootJail, "^[ \t]*RootJail[ \t]+\"(.+)\"[ \t]*$", REG_ICASE | REG_NEWLINE | REG_EXTENDED)
     || regcomp(&Daemon, "^[ \t]*Daemon[ \t]+([01])[ \t]*$", REG_ICASE | REG_NEWLINE | REG_EXTENDED)
     || regcomp(&LogFacility, "^[ \t]*LogFacility[ \t]+([a-z0-9-]+)[ \t]*$", REG_ICASE | REG_NEWLINE | REG_EXTENDED)
+    || regcomp(&LogFile, "^[ \t]*LogFile[ \t]+(.+)[ \t]*$", REG_ICASE | REG_NEWLINE | REG_EXTENDED)
     || regcomp(&LogLevel, "^[ \t]*LogLevel[ \t]+([0-5])[ \t]*$", REG_ICASE | REG_NEWLINE | REG_EXTENDED)
+    || regcomp(&ErrorLog, "^[ \t]*ErrorLog[ \t]+(.+)[ \t]*$", REG_ICASE | REG_NEWLINE | REG_EXTENDED)
     || regcomp(&Grace, "^[ \t]*Grace[ \t]+([0-9]+)[ \t]*$", REG_ICASE | REG_NEWLINE | REG_EXTENDED)
     || regcomp(&Alive, "^[ \t]*Alive[ \t]+([1-9][0-9]*)[ \t]*$", REG_ICASE | REG_NEWLINE | REG_EXTENDED)
     || regcomp(&SSLEngine, "^[ \t]*SSLEngine[ \t]+\"(.+)\"[ \t]*$", REG_ICASE | REG_NEWLINE | REG_EXTENDED)
@@ -1329,6 +1343,8 @@
     group = NULL;
     root_jail = NULL;
     ctrl_name = NULL;
+    log_file = NULL;
+    error_log = NULL;
 
     alive_to = 30;
     daemonize = 1;
@@ -1358,7 +1374,9 @@
     regfree(&RootJail);
     regfree(&Daemon);
     regfree(&LogFacility);
+    regfree(&LogFile);
     regfree(&LogLevel);
+    regfree(&ErrorLog);
     regfree(&Grace);
     regfree(&Alive);
     regfree(&SSLEngine);
--- Pound-2.4.3/pound.c	2009-01-08 19:02:26.160354939 +0200
+++ Pound-2.4.3.logsz/pound.c	2009-01-09 15:43:41.595643815 +0200
@@ -33,6 +33,8 @@
             *group,             /* group to run as */
             *root_jail,         /* directory to chroot to */
             *pid_name,          /* file to record pid in */
+            *log_file,          /* print log messages to this file, instead of syslog */
+            *error_log,         /* print error messages to this file, instead of syslog */
             *ctrl_name;         /* control socket name */
 
 int         alive_to,           /* check interval for resurrection */
@@ -54,6 +56,7 @@
         AUTHORIZATION;      /* the Authorisation header */
 
 static int  shut_down = 0;
+static int  flush_logs = 0;
 
 #ifndef  SOL_TCP
 /* for systems without the definition */
@@ -105,6 +108,33 @@
     return (unsigned long)pthread_self();
 }
 
+static void
+reopen_logs()
+{
+
+    logmsg(LOG_NOTICE, "reopening logs...");
+    // reopen logs, but check access first, as it might fail in chroot
+    if (log_file) {
+        if (access(log_file, F_OK) == 0 && access(log_file, W_OK) == -1) {
+            logmsg(LOG_ERR, "%s: %s", log_file, strerror(errno));
+        } else {
+            stdout = freopen(log_file, "a", stdout);
+            logmsg(LOG_ERR, "reopen stdout: %p", stdout);
+            setlinebuf(stdout);
+        }
+    }
+    if (error_log) {
+        if (access(error_log, F_OK) == 0 && access(error_log, W_OK) == -1) {
+            logmsg(LOG_ERR, "%s: %s", error_log, strerror(errno));
+        } else {
+            stderr = freopen(error_log, "a", stderr);
+            logmsg(LOG_ERR, "reopen stderr: %p", stderr);
+            setlinebuf(stderr);
+        }
+    }
+    flush_logs = 0;
+}
+
 /*
  * handle SIGTERM/SIGQUIT - exit
  */
@@ -142,6 +172,21 @@
 }
 
 /*
+ * handle SIGUSR1 - reopen logs
+ */
+static RETSIGTYPE
+h_reopen(const int sig)
+{
+    logmsg(LOG_NOTICE, "%d received signal %d - reopening logs...", getpid(), sig);
+    if (son > 0) {
+        reopen_logs();
+        kill(son, sig);
+    } else {
+        flush_logs = 1;
+    }
+}
+
+/*
  * Pound: the reverse-proxy/load-balancer
  *
  * Arguments:
@@ -175,6 +220,7 @@
     signal(SIGINT, h_shut);
     signal(SIGTERM, h_term);
     signal(SIGQUIT, h_term);
+    signal(SIGUSR1, h_reopen);
     signal(SIGPIPE, SIG_IGN);
 
     srandom(getpid());
@@ -289,11 +335,23 @@
         /* daemonize - make ourselves a subprocess. */
         switch (fork()) {
             case 0:
-                if(log_facility != -1) {
-                    close(0);
-                    close(1);
-                    close(2);
+                if (error_log) {
+                    stderr = freopen(error_log, "a", stderr);
+                    setlinebuf(stderr);
+                } else {
+                    if (log_facility != -1) {
+                        close(2);
+                    }
+                }
+                if (log_file) {
+                    stdout = freopen(log_file, "a", stdout);
+                    setlinebuf(stdout);
+                } else {
+                    if (log_facility != -1) {
+                        close(1);
+                    }
                 }
+                close(0);
                 break;
             case -1:
                 logmsg(LOG_ERR, "fork: %s - aborted", strerror(errno));
@@ -351,7 +409,6 @@
                 logmsg(LOG_ERR, "MONITOR: worker exited (stopped?) %d, restarting...", status);
         } else if (son == 0) {
 #endif
-
             /* thread stuff */
             pthread_attr_init(&attr);
             pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED);
@@ -392,6 +449,11 @@
                         (void)unlink(ctrl_name);
                     exit(0);
                 }
+
+				if (flush_logs) {
+                    reopen_logs();
+				}
+
                 for(lstn = listeners, i = 0; i < n_listeners; lstn = lstn->next, i++) {
                     polls[i].events = POLLIN | POLLPRI;
                     polls[i].revents = 0;
--- Pound-2.4.3-logfile/pound.h	2008-12-11 00:16:43.449299956 +0200
+++ Pound-2.4.3.logs/pound.h	2009-01-08 17:47:38.940178535 +0200
@@ -236,6 +236,8 @@
             *group,             /* group to run as */
             *root_jail,         /* directory to chroot to */
             *pid_name,          /* file to record pid in */
+            *log_file,          /* print log messages to this file, instead of syslog */
+            *error_log,         /* print error messages to this file, instead of syslog */
             *ctrl_name;         /* control socket name */
 
 extern int  alive_to,           /* check interval for resurrection */
--- Pound-2.4.3/svc.c	2009-01-14 15:16:55.002576968 +0200
+++ Pound-2.4.3/svc.c	2009-01-14 15:20:43.342553651 +0200
@@ -172,49 +172,47 @@
 #ifdef  HAVE_STDARG_H
 void
 logmsg(const int priority, const char *fmt, ...)
-{
-    char    buf[MAXBUF + 1];
-    va_list ap;
-    struct tm   *t_now, t_res;
-
-    buf[MAXBUF] = '\0';
-    va_start(ap, fmt);
-    vsnprintf(buf, MAXBUF, fmt, ap);
-    va_end(ap);
-    if(log_facility == -1) {
-        fprintf((priority == LOG_INFO || priority == LOG_DEBUG)? stdout: stderr, "%s\n", buf);
-    } else {
-        if(print_log)
-            printf("%s\n", buf);
-        else
-            syslog(log_facility | priority, "%s", buf);
-    }
-    return;
-}
 #else
 void
 logmsg(const int priority, const char *fmt, va_alist)
 va_dcl
+#endif
 {
     char    buf[MAXBUF + 1];
     va_list ap;
     struct tm   *t_now, t_res;
+    int log = (priority == LOG_INFO || priority == LOG_DEBUG);
 
     buf[MAXBUF] = '\0';
+#ifdef  HAVE_STDARG_H
+    va_start(ap, fmt);
+#else
     va_start(ap);
+#endif
     vsnprintf(buf, MAXBUF, fmt, ap);
     va_end(ap);
-    if(log_facility == -1) {
-        fprintf((priority == LOG_INFO || priority == LOG_DEBUG)? stdout: stderr, "%s\n", buf);
+
+    // if access log or error log are set, use them.
+    if (log && log_file) {
+        fprintf(stdout, "%s\n", buf);
+        return;
+    }
+    if (!log && error_log) {
+        fprintf(stderr, "%s\n", buf);
+        return;
+    }
+
+    if (log_facility == -1) {
+        fprintf(log ? stdout : stderr, "%s\n", buf);
     } else {
-        if(print_log)
+        if (print_log) {
             printf("%s\n", buf);
-        else
+		} else {
             syslog(log_facility | priority, "%s", buf);
+		}
     }
     return;
 }
-#endif
 
 /*
  * Translate inet/inet6 address/port into a string