projects / packages / libcgroup.git / blame
| Commit | Line | Data |
|---|---|---|
| 9665627f AM |
1 | From 94e9dcead2e8bce00deeef08ea364ec6dc7e1f45 Mon Sep 17 00:00:00 2001 |
| 2 | From: Michal Hocko <mhocko@suse.com> | |
| 3 | Date: Wed, 18 Jul 2018 11:24:29 +0200 | |
| 4 | Subject: [PATCH] cgrulesengd: remove umask(0) | |
| 5 | ||
| 6 | One of our partners has noticed that cgred daemon is creating a log file | |
| 7 | (/var/log/cgred) with too wide permissions (0666) and that is seen as | |
| 8 | a security bug because an untrusted user can write to otherwise | |
| 9 | restricted area. CVE-2018-14348 has been assigned to this issue. | |
| 10 | ||
| 11 | Signed-off-by: Michal Hocko <mhocko@suse.com> | |
| 12 | Acked-by: Balbir Singh <bsingharora@gmail.com> | |
| 13 | --- | |
| 14 | src/daemon/cgrulesengd.c | 3 --- | |
| 15 | 1 file changed, 3 deletions(-) | |
| 16 | ||
| 17 | diff --git a/src/daemon/cgrulesengd.c b/src/daemon/cgrulesengd.c | |
| 18 | index 170837a..41aadd4 100644 | |
| 19 | --- a/src/daemon/cgrulesengd.c | |
| 20 | +++ b/src/daemon/cgrulesengd.c | |
| 21 | @@ -885,9 +885,6 @@ int cgre_start_daemon(const char *logp, const int logf, | |
| 22 | } else if (pid > 0) { | |
| 23 | exit(EXIT_SUCCESS); | |
| 24 | } | |
| 25 | - | |
| 26 | - /* Change the file mode mask. */ | |
| 27 | - umask(0); | |
| 28 | } else { | |
| 29 | flog(LOG_DEBUG, "Not using daemon mode\n"); | |
| 30 | pid = getpid(); | |
| 31 | -- | |
| 32 | 2.17.1 | |
| 33 |