projects / packages / xen.git / blame
| Commit | Line | Data |
|---|---|---|
| 0065b9ba JR |
1 | commit 3f293c7caaefc2c37b61e44e8ebd5a7f1c554afb |
| 2 | Author: Dario Faggioli <dario.faggioli@citrix.com> | |
| 3 | Date: Thu Feb 25 13:03:04 2016 +0100 | |
| 4 | ||
| 5 | public: typo: use ' as apostrophe in grant_table.h | |
| 6 | ||
| 7 | If grep 2.23 is installed, build fails like this: | |
| 8 | ... | |
| 9 | mkdir -p compat | |
| 10 | grep -v 'DEFINE_XEN_GUEST_HANDLE(long)' public/grant_table.h | \ | |
| 11 | python /home/SOURCES/xen/xen/xen.git/xen/tools/compat-build-source.py >compat/grant_table.c.new | |
| 12 | mv -f compat/grant_table.c.new compat/grant_table.c | |
| 13 | gcc ... -o compat/grant_table.i compat/grant_table.c | |
| 14 | compat/grant_table.c:33:1: error: unterminated comment | |
| 15 | /* | |
| 16 | ^ | |
| 17 | compat/grant_table.c:28:0: error: unterminated #ifndef | |
| 18 | #ifndef __XEN_PUBLIC_GRANT_TABLE_H__ | |
| 19 | ^ | |
| 20 | Makefile:62: recipe for target 'compat/grant_table.i' failed | |
| 21 | make[3]: *** [compat/grant_table.i] Error 1 | |
| 22 | rm compat/grant_table.c | |
| 23 | make[3]: Leaving directory '/home/SOURCES/xen/xen/xen.git/xen/include' | |
| 24 | ... | |
| 25 | ||
| 26 | This is because grant_table.h contains this (note the | |
| 27 | apostrophe): "granter\92s memory", and `grep -v', in version | |
| 28 | 2.23, stops processing the file (while, for instance, | |
| 29 | until 2.22, this was not happening). | |
| 30 | ||
| 31 | Although the above behavior is likely an issue in grep, | |
| 32 | (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=22461) | |
| 33 | I think we better switch to using " ' " in that line | |
| 34 | anyway, as we do basically everywhere else (even in | |
| 35 | the same file). | |
| 36 | ||
| 37 | Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com> | |
| 38 | ||
| 39 | diff --git a/xen/include/public/grant_table.h b/xen/include/public/grant_table.h | |
| 40 | index e9393fd..e5f04ec 100644 | |
| 41 | --- a/xen/include/public/grant_table.h | |
| 42 | +++ b/xen/include/public/grant_table.h | |
| 43 | @@ -43,7 +43,7 @@ | |
| 44 | * table are identified by grant references. A grant reference is an | |
| 45 | * integer, which indexes into the grant table. It acts as a | |
| 46 | * capability which the grantee can use to perform operations on the | |
| 47 | - * granter’s memory. | |
| 48 | + * granter's memory. | |
| 49 | * | |
| 50 | * This capability-based system allows shared-memory communications | |
| 51 | * between unprivileged domains. A grant reference also encapsulates |