- rel 4; comment and attachment fixes from git

[packages/rt.git] / rt-bug-33027.patch

diff --git a/rt-bug-33027.patch b/rt-bug-33027.patch
index 4d7064bb6f49730c20f3cdc6e8a41bdfaba8af1b..0de453f2880ad992b1d9a59bf3874afdf2cbf9c0 100644 (file)
--- a/rt-bug-33027.patch
+++ b/rt-bug-33027.patch
@@ -57,3 +57,53 @@ index 075940306..8b4ba94c2 100644
     };
     updateScrips();
  
+commit b68fdcbf6006922e60afa3da247472f4b7a96bbc
+Author: sunnavy <sunnavy@bestpractical.com>
+Date:   Fri Mar 9 21:57:11 2018 +0800
+
+    Always enable recipient checkboxes
+    
+    The "disable" behavior is introduced in f0a7105d and 4b11cf37, which is
+    mainly to indicate that recipients checkboxes are being updated and
+    shouldn't be changed. It had a js execute order issue, which was fixed
+    in db6ef531. But from real user reports, there is still possibility that
+    checkboxes are not enabled in time, which causes RT to not send
+    notifications.
+    
+    It introduces so much mess but gains so less, not mentioning that the
+    0.3 opacity is already an indicator of "watch out, the section is being
+    updated".
+
+diff --git a/share/html/Ticket/Update.html b/share/html/Ticket/Update.html
+index 8b4ba94c29..f90a89a0d7 100644
+--- a/share/html/Ticket/Update.html
++++ b/share/html/Ticket/Update.html
+@@ -217,16 +217,8 @@ jQuery( function() {
+        jQuery('#recipients div.titlebox-content').addClass('refreshing');
+        jQuery('#previewscrips div.titlebox-content').addClass('refreshing');
+ 
+-       /* temporarily re-enable the checkboxes so they will be included in
+-          payload */
+-       jQuery("#recipients input[name=TxnSendMailToAll], #recipients input[name=TxnSendMailTo]").attr('disabled', false);
+-       jQuery("#previewscrips input[name=TxnSendMailToAll], #previewscrips input[name=TxnSendMailTo]").attr('disabled', false);
+-
+        var payload = jQuery('form[name=TicketUpdate]').serializeArray();
+ 
+-       jQuery("#recipients input[name=TxnSendMailToAll], #recipients input[name=TxnSendMailTo]").attr('disabled', true);
+-       jQuery("#previewscrips input[name=TxnSendMailToAll], #previewscrips input[name=TxnSendMailTo]").attr('disabled', true);
+-
+        jQuery('#recipients div.titlebox-content').load( '<% RT->Config->Get('WebPath')%>/Helpers/ShowSimplifiedRecipients',
+            payload,
+            function() {
+@@ -266,11 +258,6 @@ jQuery( function() {
+ 
+    jQuery("#ticket-update-metadata :input, #UpdateCc, #UpdateBcc").change( updateScrips );
+ 
+-   jQuery("body").on("submit", "form", function () {
+-       jQuery("#recipients input[name=TxnSendMailToAll], #recipients input[name=TxnSendMailTo]").attr('disabled', false);
+-       jQuery("#previewscrips input[name=TxnSendMailToAll], #previewscrips input[name=TxnSendMailTo]").attr('disabled', false);
+-   });
+-
+ });
+ </script>
+ % }