diff --git a/src/api.c b/src/api.c index 54a6736..1557393 100644 --- a/src/api.c +++ b/src/api.c @@ -2482,29 +2482,29 @@ static int cg_rd_ctrl_file(const char *subsys, const char *cgroup, const char *file, char **value) { char path[FILENAME_MAX]; - FILE *ctrl_file = NULL; - int ret; + int ctrl_file = -1; + ssize_t ret; if (!cg_build_path_locked(cgroup, path, subsys)) return ECGFAIL; strncat(path, file, sizeof(path) - strlen(path)); - ctrl_file = fopen(path, "re"); - if (!ctrl_file) + ctrl_file = open(path, O_RDONLY | O_CLOEXEC); + if (ctrl_file < 0) return ECGROUPVALUENOTEXIST; *value = calloc(CG_CONTROL_VALUE_MAX, 1); if (!*value) { - fclose(ctrl_file); + close(ctrl_file); last_errno = errno; return ECGOTHER; } /* - * using %as crashes when we try to read from files like + * using %as or fread crashes when we try to read from files like * memory.stat */ - ret = fread(*value, 1, CG_CONTROL_VALUE_MAX-1, ctrl_file); + ret = read(ctrl_file, *value, CG_CONTROL_VALUE_MAX-1); if (ret < 0) { free(*value); *value = NULL; @@ -2514,7 +2514,7 @@ static int cg_rd_ctrl_file(const char *subsys, const char *cgroup, (*value)[ret-1] = '\0'; } - fclose(ctrl_file); + close(ctrl_file); return 0; }