upstream fix for new geckodriver regression; rel 2

[packages/firefox.git] / geckodriver-version-check.patch

# HG changeset patch
# User Henrik Skupin <mail@hskupin.info>
# Date 1597313122 0
# Node ID 46b078983080ca4d87e2305d781855b080fc1643
# Parent  082de8244278d76f9d6d216a7fd5da772b5152d3
Bug 1658870 - [geckodriver] Remove Firefox version check for acceptInsecureCerts. r=webdriver-reviewers,jgraham

Differential Revision: https://phabricator.services.mozilla.com/D86917

diff --git a/testing/geckodriver/src/capabilities.rs b/testing/geckodriver/src/capabilities.rs
--- a/testing/geckodriver/src/capabilities.rs
+++ b/testing/geckodriver/src/capabilities.rs
@@ -127,26 +127,17 @@ impl<'a> BrowserCapabilities for Firefox
         } else if cfg!(target_os = "linux") {
             Some("linux".into())
         } else {
             None
         })
     }
 
     fn accept_insecure_certs(&mut self, _: &Capabilities) -> WebDriverResult<bool> {
-        let binary = self.chosen_binary.clone();
-        let version_str = self.version(binary.as_ref().map(|x| x.as_ref()));
-        if let Some(x) = version_str {
-            Ok(Version::from_str(&*x)
-                .or_else(|x| Err(convert_version_error(x)))?
-                .major
-                >= 52)
-        } else {
-            Ok(false)
-        }
+        Ok(true)
     }
 
     fn set_window_rect(&mut self, _: &Capabilities) -> WebDriverResult<bool> {
         Ok(true)
     }
 
     fn compare_browser_version(
         &mut self,