1 From jim@meyering.net Mon Jul 20 20:12:31 2009
2 Return-Path: jim@meyering.net
3 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on amd.home.annexia.org
5 X-Spam-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,
6 UNPARSEABLE_RELAY autolearn=ham version=3.2.5
7 Received: from mail.corp.redhat.com [10.5.5.51]
8 by amd.home.annexia.org with IMAP (fetchmail-6.3.8)
9 for <rjones@localhost> (single-drop); Mon, 20 Jul 2009 20:12:31 +0100 (BST)
10 Received: from zmta03.collab.prod.int.phx2.redhat.com (LHLO
11 zmta03.collab.prod.int.phx2.redhat.com) (10.5.5.33) by
12 mail06.corp.redhat.com with LMTP; Mon, 20 Jul 2009 15:12:17 -0400 (EDT)
13 Received: from localhost (localhost.localdomain [127.0.0.1])
14 by zmta03.collab.prod.int.phx2.redhat.com (Postfix) with ESMTP id 3C1A04E4EC
15 for <rjones@redhat.com>; Mon, 20 Jul 2009 15:12:17 -0400 (EDT)
16 Received: from zmta03.collab.prod.int.phx2.redhat.com ([127.0.0.1])
17 by localhost (zmta03.collab.prod.int.phx2.redhat.com [127.0.0.1]) (amavisd-new, port 10024)
18 with ESMTP id a+PpYwgPRjqW for <rjones@redhat.com>;
19 Mon, 20 Jul 2009 15:12:17 -0400 (EDT)
20 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
21 by zmta03.collab.prod.int.phx2.redhat.com (Postfix) with ESMTP id 130A44E4D6
22 for <rjones@mail.corp.redhat.com>; Mon, 20 Jul 2009 15:12:17 -0400 (EDT)
23 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])
24 by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n6KJCGMZ001977
25 for <rjones@int-mx2.corp.redhat.com>; Mon, 20 Jul 2009 15:12:16 -0400
26 Received: from mx.meyering.net (sebastian-int.corp.redhat.com [172.16.52.221])
27 by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n6KJCF82022169
28 for <rjones@redhat.com>; Mon, 20 Jul 2009 15:12:15 -0400
29 Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000)
30 id 36C5D38154; Mon, 20 Jul 2009 21:12:15 +0200 (CEST)
31 From: Jim Meyering <jim@meyering.net>
32 To: "Richard W. M. Jones" <rjones@redhat.com>
33 Subject: chntpw [PATCH] detect/diagnose failure to write key
34 Date: Mon, 20 Jul 2009 21:12:15 +0200
35 Message-ID: <873a8r88z4.fsf@meyering.net>
37 Content-Type: text/plain; charset=us-ascii
38 X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26
43 Hi Rich, here's another.
45 >From 057c832cf924cabf887e59d1c1f2127cd4619572 Mon Sep 17 00:00:00 2001
46 From: Jim Meyering <meyering@redhat.com>
47 Date: Mon, 20 Jul 2009 15:09:26 -0400
48 Subject: [PATCH] detect/diagnose failure to write key
50 * ntreg.c (export_key): Detect stream write failure.
53 1 files changed, 8 insertions(+), 1 deletions(-)
55 diff --git a/ntreg.c b/ntreg.c
56 index 21cd3e3..cdb6503 100644
59 @@ -2735,7 +2735,14 @@ void export_key(struct hive *hdesc, int nkofs, char *name, char *filename, char
60 fprintf(file, "Windows Registry Editor Version 5.00\r\n\r\n");
61 export_subkey(hdesc, nkofs, name, prefix, file);
64 + if (ferror (file)) {
65 + printf("failed to write file '%s'\n", filename);
70 + printf("failed to write file '%s': %s\n", filename,