-https://bugs.freedesktop.org/show_bug.cgi?id=53837
+From: Michael Biebl <biebl@debian.org>
+Date: Thu, 18 Jul 2013 01:04:07 +0200
+Subject: Revert "udev: network device renaming - immediately give up if the
+ target name isn't available"
-Kay Sievers <kay@vrfy.org> changed:
+This reverts commit 97595710b77aa162ca5e20da57d0a1ed7355eaad.
- What |Removed |Added
-----------------------------------------------------------------------------
- Status|NEW |RESOLVED
- Resolution| |WONTFIX
-
---- Comment #1 from Kay Sievers <kay@vrfy.org> 2012-08-20 12:12:56 UTC ---
-Please use biosdevname or name the devices other than ethX.
-
-We do not try to race against the kernel anymore, and therefore do not
-support swapping names around in the kernel namespace.
-
-In short: Devices can no longer be renamed to ethX.
-
-============================================================================
-
-Revert 97595710b77aa162ca5e20da57d0a1ed7355eaad
-
-From: Kay Sievers <kay@vrfy.org>
-Date: Thu, 05 Jul 2012 15:40:50 +0000
-Subject: udev: network device renaming - immediately give up if the target name isn't available
-
-diff --git a/src/udev/udev-event.c b/src/udev/udev-event.c
-index 2ade0ab..aff1487 100644
---- a/src/udev/udev-event.c
-+++ b/src/udev/udev-event.c
-@@ -745,11 +745,32 @@ out:
- return err;
- }
+We need to keep supporting systems with 75-persistent-net-generator.rules
+generated names for a while after switching to net.ifnames. Re-apply this old
+hack to make the renaming less likely to fail.
+---
+--- systemd-242/src/udev/udev-event.c.orig 2019-04-11 18:28:36.000000000 +0200
++++ systemd-242/src/udev/udev-event.c 2019-04-13 14:19:13.346990771 +0200
+@@ -698,6 +698,8 @@
+ sd_device *dev = event->dev;
+ const char *oldname;
+ int ifindex, r;
++ char name[IFNAMSIZ];
++ int loop;
-+static void rename_netif_kernel_log(struct ifreq ifr)
-+{
-+ int klog;
-+ FILE *f;
-+
-+ klog = open("/dev/kmsg", O_WRONLY|O_CLOEXEC);
-+ if (klog < 0)
-+ return;
-+
-+ f = fdopen(klog, "w");
-+ if (f == NULL) {
-+ close(klog);
-+ return;
-+ }
+ if (!event->name)
+ return 0; /* No new name is requested. */
+@@ -719,22 +720,66 @@
+ return log_device_error_errno(dev, r, "Failed to get ifindex: %m");
+
+ r = rtnl_set_link_name(&event->rtnl, ifindex, event->name);
++ if (r >= 0) {
++ /* Set ID_RENAMING boolean property here, and drop it in the corresponding move uevent later. */
++ r = device_add_property(dev, "ID_RENAMING", "1");
++ if (r < 0)
++ log_device_warning_errno(dev, r, "Failed to add 'ID_RENAMING' property: %m");
+
-+ fprintf(f, "<30>udevd[%u]: renamed network interface %s to %s\n",
-+ getpid(), ifr.ifr_name, ifr.ifr_newname);
-+ fclose(f);
-+}
++ r = device_rename(dev, event->name);
++ if (r < 0)
++ log_device_warning_errno(dev, r, "Failed to update properties with new name '%s': %m", event->name);
+
- static int rename_netif(struct udev_event *event)
- {
- struct udev_device *dev = event->dev;
- int sk;
- struct ifreq ifr;
-+ int loop;
- int err;
-
- log_debug("changing net interface name from '%s' to '%s'\n",
-@@ -766,12 +787,49 @@ static int rename_netif(struct udev_event *event)
- strscpy(ifr.ifr_name, IFNAMSIZ, udev_device_get_sysname(dev));
- strscpy(ifr.ifr_newname, IFNAMSIZ, event->name);
- err = ioctl(sk, SIOCSIFNAME, &ifr);
-- if (err >= 0) {
-- print_kmsg("renamed network interface %s to %s\n", ifr.ifr_name, ifr.ifr_newname);
-- } else {
-+ if (err == 0) {
-+ rename_netif_kernel_log(ifr);
-+ goto out;
++ log_device_debug(dev, "Network interface %i is renamed from '%s' to '%s'", ifindex, oldname, event->name);
++ return 1;
+ }
+
+ /* keep trying if the destination interface name already exists */
-+ err = -errno;
-+ if (err != -EEXIST)
++ if (r != -EEXIST)
+ goto out;
+
+ /* free our own name, another process may wait for us */
-+ snprintf(ifr.ifr_newname, IFNAMSIZ, "rename%u", udev_device_get_ifindex(dev));
-+ err = ioctl(sk, SIOCSIFNAME, &ifr);
-+ if (err < 0) {
- err = -errno;
-- log_error("error changing net interface name %s to %s: %m\n", ifr.ifr_name, ifr.ifr_newname);
++ snprintf(name, IFNAMSIZ, "rename%u", ifindex);
++ r = rtnl_set_link_name(&event->rtnl, ifindex, name);
+ if (r < 0)
+- return log_device_error_errno(dev, r, "Failed to rename network interface %i from '%s' to '%s': %m",
+- ifindex, oldname, event->name);
+ goto out;
-+ }
-+
++
+ /* log temporary name */
-+ rename_netif_kernel_log(ifr);
-+
++ log_device_debug(dev, "Network interface %i is renamed from '%s' to '%s'", ifindex, oldname, event->name);
+
+- /* Set ID_RENAMING boolean property here, and drop it in the corresponding move uevent later. */
+- r = device_add_property(dev, "ID_RENAMING", "1");
+- if (r < 0)
+- return log_device_warning_errno(dev, r, "Failed to add 'ID_RENAMING' property: %m");
+ /* wait a maximum of 90 seconds for our target to become available */
-+ strscpy(ifr.ifr_name, IFNAMSIZ, ifr.ifr_newname);
-+ strscpy(ifr.ifr_newname, IFNAMSIZ, event->name);
++ strscpy(name, IFNAMSIZ, event->name);
+ loop = 90 * 20;
+ while (loop--) {
+ const struct timespec duration = { 0, 1000 * 1000 * 1000 / 20 };
+
+ nanosleep(&duration, NULL);
+
-+ err = ioctl(sk, SIOCSIFNAME, &ifr);
-+ if (err == 0) {
-+ rename_netif_kernel_log(ifr);
-+ break;
-+ }
-+ err = -errno;
-+ if (err != -EEXIST)
-+ break;
- }
++ r = rtnl_set_link_name(&event->rtnl, ifindex, name);
++ if (r >= 0) {
++ /* Set ID_RENAMING boolean property here, and drop it in the corresponding move uevent later. */
++ r = device_add_property(dev, "ID_RENAMING", "1");
++ if (r < 0)
++ log_device_warning_errno(dev, r, "Failed to add 'ID_RENAMING' property: %m");
+
++ r = device_rename(dev, event->name);
++ if (r < 0)
++ log_device_warning_errno(dev, r, "Failed to update properties with new name '%s': %m", event->name);
++
++ log_device_debug(dev, "Network interface %i is renamed from '%s' to '%s'", ifindex, oldname, event->name);
++ return 1;
++ }
++ if (r != -EEXIST)
++ goto out;
++ }
+
+- r = device_rename(dev, event->name);
+out:
-+ if (err < 0)
-+ log_error("error changing net interface name %s to %s: %m\n", ifr.ifr_name, ifr.ifr_newname);
- close(sk);
- return err;
+ if (r < 0)
+- return log_device_warning_errno(dev, r, "Failed to update properties with new name '%s': %m", event->name);
++ return log_device_error_errno(dev, r, "Failed to rename network interface %i from '%s' to '%s': %m",
++ ifindex, oldname, event->name);
++ return r;
+
+- log_device_debug(dev, "Network interface %i is renamed from '%s' to '%s'", ifindex, oldname, event->name);
+
+- return 1;
}
+
+ static int update_devnode(UdevEvent *event) {
projects / packages / systemd.git / blobdiff