diff -urN exim-4.71/src/spam.c exim-4.71-new/src/spam.c --- exim-4.71/src/spam.c 2008-07-18 18:55:42.000000000 +0100 +++ exim-4.71-new/src/spam.c 2009-12-17 12:37:14.000000000 +0000 @@ -104,10 +104,8 @@ /* socket does not start with '/' -> network socket */ if (*spamd_address_work != '/') { - time_t now = time(NULL); int num_servers = 0; - int current_server = 0; - int start_server = 0; + int current_server; uschar *address = NULL; uschar *spamd_address_list_ptr = spamd_address_work; uschar address_buffer[256]; @@ -119,6 +117,7 @@ address_buffer, sizeof(address_buffer))) != NULL) { + /* Potential memory leak as we never free the store. */ spamd_address_container *this_spamd = (spamd_address_container *)store_get(sizeof(spamd_address_container)); @@ -143,9 +142,10 @@ return DEFER; }; - current_server = start_server = (int)now % num_servers; + while ( num_servers > 0 ) { - while (1) { + /* Randomly pick a server to try */ + current_server = random_number( num_servers ); debug_printf("trying server %s, port %u\n", spamd_address_vector[current_server]->tcp_addr, @@ -173,16 +173,21 @@ spamd_address_vector[current_server]->tcp_addr, spamd_address_vector[current_server]->tcp_port, strerror(errno)); - current_server++; - if (current_server >= num_servers) - current_server = 0; - if (current_server == start_server) { - log_write(0, LOG_MAIN|LOG_PANIC, "spam acl condition: all spamd servers failed"); - (void)fclose(mbox_file); - (void)close(spamd_sock); - return DEFER; - }; - }; + + (void)close(spamd_sock); + + /* Remove the server from the list. XXX We should free the memory */ + num_servers--; + int i; + for( i = current_server; i < num_servers; i++ ) + spamd_address_vector[i] = spamd_address_vector[i+1]; + } + + if ( num_servers == 0 ) { + log_write(0, LOG_MAIN|LOG_PANIC, "spam acl condition: all spamd servers failed"); + (void)fclose(mbox_file); + return DEFER; + } } else {