1 From: Volker Lendecke <vl@samba.org>
2 Date: Tue, 10 Mar 2009 15:08:38 +0000 (+0100)
3 Subject: Revert "Revert "Fix a valgrind error / segfault in dns_register_smbd()""
4 X-Git-Url: http://gitweb.samba.org/?p=samba.git;a=commitdiff_plain;h=8cb0d6280ecc62d03ea6fb5e522f57a80d9e0262
6 Revert "Revert "Fix a valgrind error / segfault in dns_register_smbd()""
8 This reverts commit 96c57d26ed790b3e94c935cc4faf5661ea43a80c.
10 It is REALLY, REALLY confusing that the 3_X_test build in the build farm
14 diff --git a/source/smbd/dnsregister.c b/source/smbd/dnsregister.c
15 index 6850d1a..ff9be43 100644
16 --- a/source/smbd/dnsregister.c
17 +++ b/source/smbd/dnsregister.c
18 @@ -108,7 +108,8 @@ void dns_register_smbd(struct dns_reg_state ** dns_state_ptr,
19 struct dns_reg_state *dns_state = *dns_state_ptr;
21 if (dns_state == NULL) {
22 - *dns_state_ptr = dns_state = talloc(NULL, struct dns_reg_state);
23 + dns_state = talloc_zero(NULL, struct dns_reg_state);
24 + *dns_state_ptr = dns_state;
25 if (dns_state == NULL) {