1 From ak@suse.de Mon Mar 12 01:31:09 2007
2 Return-path: <ak@suse.de>
3 Envelope-to: qrczak@qrnik.knm.org.pl
4 Delivery-date: Mon, 12 Mar 2007 01:31:09 +0100
5 Received: from hell.pl ([193.219.28.162]:37749 ident=Debian-exim) by
6 qrnik.knm.org.pl with esmtp (Exim 4.66) (envelope-from <ak@suse.de>) id
7 1HQYRQ-0002bu-WF for qrczak@qrnik.knm.org.pl; Mon, 12 Mar 2007 01:31:09
9 Received: from cantor2.suse.de ([195.135.220.15] helo=mx2.suse.de) by
10 hell.pl with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.63)
11 (envelope-from <ak@suse.de>) id 1HQYRQ-0004gE-M9 for qrczak@knm.org.pl;
12 Mon, 12 Mar 2007 01:31:08 +0100
13 Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1
14 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate
15 requested) by mx2.suse.de (Postfix) with ESMTP id 93807215E0; Mon, 12 Mar
16 2007 01:19:47 +0100 (CET)
18 To: Marcin 'Qrczak' Kowalczyk <qrczak@knm.org.pl>
19 Cc: linux-kernel@vger.kernel.org
20 Subject: Re: _proxy_pda still makes linking modules fail
21 References: <1173315479.12472.9.camel@qrnik>
22 From: Andi Kleen <andi@firstfloor.org>
23 Date: 12 Mar 2007 02:19:05 +0100
24 In-Reply-To: <1173315479.12472.9.camel@qrnik>
25 Message-ID: <p73lki39s3a.fsf@bingen.suse.de>
27 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
29 Content-Type: text/plain; charset=us-ascii
30 X-Evolution-Source: mbox:///var/mail/qrczak
31 Content-Transfer-Encoding: 8bit
33 Marcin 'Qrczak' Kowalczyk <qrczak@knm.org.pl> writes:
35 > I've heard that it now builds with gcc-4.2.0 snapshots. This is strange:
36 > if the problem has been fixed for gcc-4.2.0, why doesn't it work for
37 > gcc-4.1.2? arch/i386/kernel/vmlinux.lds.S does contain _proxy_pda = 0;
39 Hmm, it probably needs a EXPORT_SYMBOL. The previous change only
40 fixed the in kernel build.
42 Does it work with this patch?
46 Export _proxy_pda for gcc 4.2
48 The symbol is not actually used, but the compiler unforunately generates
49 a (unused) reference to it. This can happen even in modules. So export it.
51 Signed-off-by: Andi Kleen <ak@suse.de>
53 Index: linux/arch/i386/kernel/i386_ksyms.c
54 ===================================================================
55 --- linux.orig/arch/i386/kernel/i386_ksyms.c
56 +++ linux/arch/i386/kernel/i386_ksyms.c
57 @@ -28,3 +28,5 @@ EXPORT_SYMBOL(__read_lock_failed);
60 EXPORT_SYMBOL(csum_partial);
62 +EXPORT_SYMBOL(_proxy_pda);
63 Index: linux/arch/x86_64/kernel/x8664_ksyms.c
64 ===================================================================
65 --- linux.orig/arch/x86_64/kernel/x8664_ksyms.c
66 +++ linux/arch/x86_64/kernel/x8664_ksyms.c
67 @@ -61,3 +61,4 @@ EXPORT_SYMBOL(empty_zero_page);
68 EXPORT_SYMBOL(init_level4_pgt);
69 EXPORT_SYMBOL(load_gs_index);
71 +EXPORT_SYMBOL(_proxy_pda);