1 From MAILER-DAEMON Tue Sep 23 08:36:48 2003
2 Date: 23 Sep 2003 08:36:48 +0000
3 From: Mail System Internal Data <MAILER-DAEMON@alpha.zarz.agh.edu.pl>
4 Subject: DON'T DELETE THIS MESSAGE -- FOLDER INTERNAL DATA
5 X-IMAP: 1064306208 0000000000
8 This text is part of the internal format of your mail folder, and is not
9 a real message. It is created automatically by the mail system software.
10 If deleted, important folder data will be lost, and it will be re-created
11 with the data reset to initial values.
13 From cieciwa@alpha.zarz.agh.edu.pl Tue Sep 23 00:47:22 2003 +0000
17 Return-Path: <linux-kernel-owner+cieciwa=40alpha.zarz.agh.edu.pl@vger.kernel.org>
18 X-Original-To: cieciwa@alpha.zarz.agh.edu.pl
19 Delivered-To: cieciwa@alpha.zarz.agh.edu.pl
20 Received: from galaxy.uci.agh.edu.pl (galaxy.uci.agh.edu.pl [149.156.96.9])
21 by alpha.zarz.agh.edu.pl (Postfix) with ESMTP id D1686241A5
22 for <cieciwa@alpha.zarz.agh.edu.pl>; Tue, 23 Sep 2003 00:47:22 +0000 (UTC)
23 Received: from vger.kernel.org (vger.kernel.org [67.72.78.212])
24 by galaxy.uci.agh.edu.pl (Postfix) with ESMTP id A3C08AF49E
25 for <cieciwa@alpha.zarz.agh.edu.pl>; Tue, 23 Sep 2003 00:59:47 +0200 (CEST)
26 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
27 id S261758AbTIVW4M (ORCPT <rfc822;cieciwa@alpha.zarz.agh.edu.pl>);
28 Mon, 22 Sep 2003 18:56:12 -0400
29 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261808AbTIVW4M
30 (ORCPT <rfc822;linux-kernel-outgoing>);
31 Mon, 22 Sep 2003 18:56:12 -0400
32 Received: from fw.osdl.org ([65.172.181.6]:10978 "EHLO mail.osdl.org")
33 by vger.kernel.org with ESMTP id S261758AbTIVWzk (ORCPT
34 <rfc822;linux-kernel@vger.kernel.org>);
35 Mon, 22 Sep 2003 18:55:40 -0400
36 Received: (from chrisw@localhost)
37 by mail.osdl.org (8.11.6/8.11.6) id h8MMsuj13008;
38 Mon, 22 Sep 2003 15:54:56 -0700
39 Date: Mon, 22 Sep 2003 15:54:56 -0700
40 From: Chris Wright <chrisw@osdl.org>
41 To: David Yu Chen <dychen@stanford.edu>
42 Cc: linux-kernel@vger.kernel.org, mc@cs.stanford.edu,
43 James.Bottomley@steeleye.com
44 Subject: Re: [CHECKER] 32 Memory Leaks on Error Paths
45 Message-ID: <20030922155456.E18606@osdlab.pdx.osdl.net>
46 References: <200309160435.h8G4ZkQM009953@elaine4.Stanford.EDU>
48 Content-Type: text/plain; charset=us-ascii
49 Content-Disposition: inline
50 User-Agent: Mutt/1.2.5i
51 In-Reply-To: <200309160435.h8G4ZkQM009953@elaine4.Stanford.EDU>; from dychen@stanford.edu on Mon, Sep 15, 2003 at 09:35:46PM -0700
52 Sender: linux-kernel-owner@vger.kernel.org
54 X-Mailing-List: linux-kernel@vger.kernel.org
56 * David Yu Chen (dychen@stanford.edu) wrote:
57 > [FILE: 2.6.0-test5/drivers/scsi/NCR_Q720.c]
59 > 153: p = kmalloc(sizeof(*p), GFP_KERNEL);
61 > 155: return -ENOMEM;
63 > 180: if(i != NCR_Q720_MCA_ID) {
64 > 181: printk(KERN_ERR "NCR_Q720, adapter failed to I/O map registers correctly at 0x%x(0x%x)\n", io_base, i);
66 > 182: return -ENODEV;
68 Yes, looks like a valid bug. Patch below. James, look ok?
72 ===== drivers/scsi/NCR_Q720.c 1.4 vs edited =====
73 --- 1.4/drivers/scsi/NCR_Q720.c Sun Aug 17 13:10:45 2003
74 +++ edited/drivers/scsi/NCR_Q720.c Mon Sep 22 15:05:02 2003
76 i = inb(io_base) | (inb(io_base+1)<<8);
77 if(i != NCR_Q720_MCA_ID) {
78 printk(KERN_ERR "NCR_Q720, adapter failed to I/O map registers correctly at 0x%x(0x%x)\n", io_base, i);
83 /* Phase II, find the ram base and memory map the board register */
85 To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
86 the body of a message to majordomo@vger.kernel.org
87 More majordomo info at http://vger.kernel.org/majordomo-info.html
88 Please read the FAQ at http://www.tux.org/lkml/